Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm.js mirrors itself on other electron windows #4014

Closed
FormalSnake opened this issue Aug 17, 2022 · 4 comments
Closed

xterm.js mirrors itself on other electron windows #4014

FormalSnake opened this issue Aug 17, 2022 · 4 comments
Labels
type/question A question on how to use the library

Comments

@FormalSnake
Copy link

Details

  • Browser and browser version: Electron 18.3.5
  • OS version: macOS 13.0
  • xterm.js version: 4.18.0

I don't think it is electron's fault, because normally every letter would be double, which i managed to fix by putting every browserWindow in a let variable.

When having multiple windows in Electron, inputting something in xterm.js just mirrors on other windows, what causes the issue?
Check video below, because this is hard to explain

Screen.Recording.2022-08-17.at.11.38.01.mov

.

@FormalSnake
Copy link
Author

It might be an issue with pty itself, if it is that, please tell me.

@Tyriar
Copy link
Member

Tyriar commented Aug 17, 2022

You're likely connecting both windows to the same pty, so the input gets sent to the pty and the output/instructions get sent to both xterm.js instances. Either that or an issue with your IPC.

@Tyriar Tyriar closed this as completed Aug 17, 2022
@Tyriar Tyriar added the type/question A question on how to use the library label Aug 17, 2022
@FormalSnake
Copy link
Author

You're likely connecting both windows to the same pty, so the input gets sent to the pty and the output/instructions get sent to both xterm.js instances. Either that or an issue with your IPC.

I think i am connecting both windows to the same pty instances, but how would one make a new pty process spawn every time a window opens?

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2022

@FormalSnake this is more of a general electron IPC question than something related to xterm.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question A question on how to use the library
Projects
None yet
Development

No branches or pull requests

2 participants