Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull web link support into an addon #1298

Merged
merged 4 commits into from
Mar 6, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 23, 2018

Fixes #1297


The main motivation behind this is to slim down the xterm.js API and move the complexity of customizing the web link handler into an addon. To customize it you can now do this:

term.webLinksInit(
  /* handler */ console.log,
  /* options */ {
    validationCallback: (uri, cb) => { console.log('validate', arguments); cb(true); }
  }
);

A nice benefit of doing this is that it makes both the web links and the linkifier seem much simpler as they're now separates into different files.

@Tyriar Tyriar added this to the 3.2.0 milestone Feb 23, 2018
@Tyriar Tyriar self-assigned this Feb 23, 2018
@mofux
Copy link
Contributor

mofux commented Mar 5, 2018

LGTM 👍

@Tyriar Tyriar merged commit 6e546c0 into xtermjs:master Mar 6, 2018
@Tyriar Tyriar deleted the 1297_webLinks_addon branch March 6, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants