Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xterm.js Docker image to documentation #1313

Merged
merged 2 commits into from
Mar 7, 2018
Merged

Add xterm.js Docker image to documentation #1313

merged 2 commits into from
Mar 7, 2018

Conversation

parisk
Copy link
Contributor

@parisk parisk commented Mar 7, 2018

Closes #1295

@parisk parisk added this to the 3.2.0 milestone Mar 7, 2018
Tyriar
Tyriar approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at some point it might be good to document the release steps as well

@parisk parisk merged commit 6741e92 into master Mar 7, 2018
@parisk parisk deleted the docker-image branch March 7, 2018 21:00
@parisk
Copy link
Contributor Author

parisk commented Mar 7, 2018

@Tyriar I have set up automated builds for the Docker image, so it pretty much happens on its own when we push to master and when we push a new tag.

@Tyriar
Copy link
Member

Tyriar commented Mar 8, 2018

Nice 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parisk @Tyriar