Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose: create xterm.js organization on the dockerhub and push xterm.js image to the dockerhub. #1295

Closed
AndrienkoAleksandr opened this issue Feb 22, 2018 · 1 comment
Assignees
Labels
type/documentation Regarding website, API documentation, README, etc.
Milestone

Comments

@AndrienkoAleksandr
Copy link
Contributor

It would be nice to have official docker image xterm.js on the dockerhub. After each release you can create new latest docker image with version tag. It's usefull for some new customers who want to try xterm.js without installation node, npm. They simply do "docker run" with xterm.js image and then tests xterm.js like docker application. For now you have dockerfile. So I don't think it's a problem to create xterm.js organization on the dockerhub and begin to do realese docker image after each realease xterm.js.

@parisk
Copy link
Contributor

parisk commented Feb 23, 2018

Totally right!

Created the Docker Hub repo: https://hub.docker.com/r/xtermjs/xterm.js/ and added builds for master and for pushed tags. Now you can run the following to get the demo server working:

docker run -p 3000 xtermjs/xterm.js 

Keeping this issue open, in order to document this till the next release.

@parisk parisk added the type/documentation Regarding website, API documentation, README, etc. label Feb 23, 2018
@parisk parisk added this to the 3.2.0 milestone Feb 23, 2018
parisk added a commit that referenced this issue Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation Regarding website, API documentation, README, etc.
Projects
None yet
Development

No branches or pull requests

2 participants