Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2151
This adds extra handling to avoid canceling
keydown
events dead keys, since canceling a dead key's ownkeydown
will cancel the futurekeydown
for the combined character.The typical event flow for e.g.
Swedish Tilde
+Forward Slash
is:While canceling keydown (current):
Without canceling keydown (fixed):
For clarity, we want to let through the next
keydown
event that is responsible for a futurekeypress
/input
(so not just the "next" one since it might be a modifier key), hence the order of the checks.