Dead keys incorrectly handled by the terminal - issue is really in xterm.js

[fperez]

Description

This is really a bug in xterm.js - I'm opening this one so we can track its resolution over there and make the appropriate port (plus testing that any suggested fix actually works for us).

I've comented here on the xtermjs repo. That issue was recently closed (not sure why as I still see the problem on xtermjs.org), but hopefully the team will still respond. I'll update this if I end up opening a new issue there or they send me elsewhere.

Not much else to do here for now, til there's an upstream fix coming (or someone here knows what to do and wants to help the xterm team :)

Action: update our copy to 4.14 when released

As @Tyriar explains below, the problem is fixed in xterm.js and will be part of the 4.14 release. We can close this on our end then once we update to that version.

[Tyriar]

FYI xtermjs.org is on the stable 4.13 so the fixes won't be there yet. This is fixed afaik with xtermjs/xterm.js#3430, xtermjs/xterm.js#3432 and xtermjs/xterm.js#3437

[fperez]

Ah, cool, thanks @Tyriar, I understand now.

Great to know this is now getting fixed upstream, we can update then the version on our end when 4.14 is out with these improvements.

I hope the comment about the PC-International layout is useful to your team - I've used that layout on Macs, Windows and Linux and it offers an easy way to get dead keys on regular US keyboards, so perhaps it can be of help. I saw some comments about folks having a hard time testing some of this behavior b/c they only had US keyboards, which is why I mentioned it.

Thanks for the quick response, and more importantly the great tool! We really benefit a lot from it in Jupyter, so your work is much appreciated.

[arivero]

Surely related to this, the terminal shows a strange layout when I use a Spanish Keyboard

\1234567890[]
qwertyuiop[=
asdfghjkl`'/
\zxcvbnm,.-
|!@#$%^&*(){}
QWERTYUIOP{+
ASDFGHJKL~"?
|ZXCVBNM<>_

[pacha]

Hi, it seems that xtermjs 4.14.1 is already available (https://github.com/xtermjs/xterm.js/releases/tag/4.14.1). @fperez do you know if there are plans to update the version of the library in JupyterLab?
Also, many thanks to xtermjs for fixing the issue! 🙂

[fperez]

I'm not sure if there are any blockers to include this in a future JLab release, but it would be great to see it go in... I'll try to do a bit of testing and will report back.