-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shift() when reducing lines to preserve lines up to cursor #50
Conversation
Hi @blink1073, thanks for opening this. Attempted to try this and I fell into the following issue, which was not present before:
Could you please try a similar case in jupyter-js-ui to see if this happens there as well? |
Hi @parisk, I don't have the infrastructure set up to use xterm at the moment. We have been using term.js in Jupyter and I hand-modified these lines in |
Okay @blink1073. Please let me make a couple of tests more, to see where the bug is and I will get back to you within the next hours most probably. |
I was able to swap in xterm for term.js in my application and verify that this fix works. |
Thanks @blink1073 for letting me know. I still got the issue faced. Please let me do some more tests, to find out what might be going wrong. Seems quite strange. |
Do you have any public branch of your application that I could clone to test out myself, in order to find out if something goes wrong with my system? |
This setup requires Python installed with the Jupyter Notebook. The easiest way to get there is using Anaconda: https://www.continuum.io/downloads
I've been running |
@blink1073 I followed your instructions step-by-step and the iPython notebook does not seem to use xterm.js as its terminal. Could you please point out if am I doing something wrong and how to fix it? Providing logs and screenshots below in order to be as helpful as possible. Note Software versions
Terminal logs
ScreenshotsOccupied ports (nothing listens on 8765)Non-accessible at localhost:8765Notebook home pageTerminal is not xterm.js |
@blink1073 nevermind. Got it working. On the issue right now |
Everything seems to be working great 😊 . Thanks for your contribution! |
Sweet, my pleasure. |
The previous behavior of a resize to a smaller height kept the start of the buffer and tacked on a prompt line. This fix allows the text up to the existing prompt to be preserved.