Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetCellValue is concurrency unsafe, maybe occur fatal error: concurrent map writes #1687

Closed
jarcoug opened this issue Oct 10, 2023 · 1 comment
Closed

GetCellValue is concurrency unsafe, maybe occur fatal error: concurrent map writes #1687

jarcoug opened this issue Oct 10, 2023 · 1 comment
Labels
bug Something isn't working
Projects
v2.8.1

Comments

@jarcoug
Copy link

jarcoug commented Oct 10, 2023

https://github.com/qax-os/excelize/blob/d133dc12d774dcf944b36720f25e1dd945dda63f/excelize.go#L280C3-L280C3

f.xmlAttr is define Map, so concurrent invoke GetCellValue, maybe occur fatal error: concurrent map writes
@xuri xuri added the bug Something isn't working label Oct 10, 2023
@xuri xuri added this to Bugfix in v2.8.1 Oct 10, 2023
@xuri xuri added the in progress Working in progress label Oct 10, 2023
@xuri xuri closed this as completed in d9a0da7 Oct 10, 2023
@xuri
Copy link
Member

xuri commented Oct 10, 2023

Thanks for your issue. This issue has been fixed, please try to upgrade the master branch code, and this patch will be released in the next version.

@xuri xuri removed the in progress Working in progress label Oct 10, 2023
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
@xuri
This closes qax-os#1687 and closes qax-os#1688
e27e81f 
- Using sync map internally to get cell value concurrency safe
- Support set the height and width for the comment box
- Update the unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
v2.8.1
Bugfix
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuri @jarcoug