Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't "Save & View" a diagram on IE 11 #134

Closed
ane-gabriela opened this issue Apr 13, 2020 · 1 comment · Fixed by #143
Closed

Can't "Save & View" a diagram on IE 11 #134

ane-gabriela opened this issue Apr 13, 2020 · 1 comment · Fixed by #143
Assignees
@oanalavinia
Labels
Priority: Blocker Type: Bug
Milestone
1.13.1

Comments

@ane-gabriela
Copy link

ane-gabriela commented Apr 13, 2020 •
edited
Loading

Steps to reproduce:

  1. Create a new diagram with some shapes
  2. Click on Save & View

Expected results: The diagram is saved.

Actual results: The Save & View button becomes disabled but the page remains blocked and nothing happens, the page is not saved.

Environment: XWiki 11.10.4 with MySQL 5.7 and IE 11, Diagram Application (Pro) 1.13

IE11Save View
@ane-gabriela ane-gabriela added this to the 1.14 milestone Apr 13, 2020
@ane-gabriela ane-gabriela changed the title Can't save a diagram on IE 11 Can't "Save & View" a diagram on IE 11 Apr 14, 2020
@oanalavinia oanalavinia self-assigned this May 7, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue May 8, 2020
@oanalavinia
Can't "Save & View" a diagram on IE 11 xwikisas#134
9e24228 
* .append(), .includes()  are not supported by IE and .parentElement is not returning for svg elements in IE
oanalavinia added a commit that referenced this issue May 8, 2020
@oanalavinia
Can't "Save & View" a diagram on IE 11 #134 (#143)
2c20541 
* .append(), .includes()  are not supported by IE and .parentElement is not returning for svg elements in IE
@oanalavinia
Copy link

Note that I have opened a more general issue #144 that is valid for other browsers as well. Closing this issue separately since there were specific cases for IE

@oanalavinia oanalavinia modified the milestones: 1.14, 1.13.1 May 8, 2020
@oanalavinia oanalavinia linked a pull request May 8, 2020 that will close this issue
Can't "Save & View" a diagram on IE 11 #134 #143
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Blocker Type: Bug
Projects
None yet
Milestone
1.13.1
Development

Successfully merging a pull request may close this issue.

Can't "Save & View" a diagram on IE 11 #134 oanalavinia/application-diagram
2 participants
@oanalavinia @ane-gabriela