Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agenda tab appears as "plainList" and doesn't show any results #42

Closed
ane-gabriela opened this issue Jul 20, 2020 · 3 comments
Closed

Agenda tab appears as "plainList" and doesn't show any results #42

ane-gabriela opened this issue Jul 20, 2020 · 3 comments
Assignees
@acotiuga
Labels
Priority: Critical Type: Bug
Milestone
2.9.2

Comments

@ane-gabriela
Copy link

Steps to reproduce:

  1. Create some events in the past, present and in the future on the same or different calendars
  2. Click on the "Agenda" tag
  3. Click on the previous and next buttons

Expected results: The past / present and future events are shown in the respective selection. The previous and next buttons are disabled when the user reaches the end of the events.

OldView

Actual results: No events are shown, the tag Agenda appears as "plainList".

NoAgenda

Environment: Windows 10, XWiki 12.5.1 with MySQL 8.0 and IE 11, Calendar Application (Pro) 2.8.10
@ane-gabriela ane-gabriela added this to the 2.9 milestone Jul 20, 2020
@acotiuga acotiuga removed this from the 2.9 milestone Nov 12, 2020
@acotiuga acotiuga self-assigned this Nov 23, 2020
@acotiuga acotiuga added this to the 2.9.2 milestone Nov 23, 2020
@acotiuga
Copy link

The upgrade to Full Calendar Macro 2.0.4 determined some changes in the UI, implemented in (3e30666). One of them is the usage of the plainList naming over the agenda. The bug about not listing the events in plainList view is caused by the usage of the undefined moment library.

acotiuga added a commit that referenced this issue Nov 24, 2020
@acotiuga
Agenda tab appears as "plainList" and doesn't show any results #42
40f1ffd 
* the "agenda" view was replaced by the "plainList" view, so the new translations reflect the new case
* the result were not displayed because of JS error caused by the usage of undefined "moment.js" library
@acotiuga
Copy link

New look in the Plain list view:
listeSimple

acotiuga added a commit that referenced this issue Nov 24, 2020
@acotiuga
Agenda tab appears as "plainList" and doesn't show any results #42
4bf52d0 
* let's actually keep the agenda naming, for the simple reson that it sounds better then plain list
@acotiuga
Copy link

acotiuga commented Dec 2, 2020

For the "The previous and next buttons are disabled when the user reaches the end of the events." I created a new ticket: #56

ClemensRobbenhaar added a commit that referenced this issue Sep 24, 2021
@ClemensRobbenhaar
Merge remote-tracking branch 'upstream/master' into ckr-merge-upstream
47d363d 
Actually merge from the xwiki-contrib version.

The main new feature (recurrent events) are still disabled
after the merge as some UI elements where not really stable, namely
the date pickers. See MoccaCalendarEventSheet for the simple
"#if(false)" clauses disabling it.

Conflicts have been resolved as:

MoccaCalendarTranslations.*
   - added translations for recurrent events
   - added missing MoccaCalendarMacroTranslations from e.x.o version
     or add placeholders for them where missing

Code/WebHome
   - the automatic merge confused the page with the (also moved)
     MoccaCalendarEventLiveTableResults

Code/Macro
  - the improved "Delete event" modal (#14)
    needed to be merged with the "delete all instances" implementation
    it now has an extra buttom "delete all" only shown for recurrent events
  - upstream added newPageNameUrl, dateCheckUrl, deleteEventInstanceUrl to calendar.Helper
    for the new separate services split from the JSONService; now list each
    of them on a separate line for better reading

JSONService -> Code/JSONService, etc.
  - upstream service got distributed to several services pages in Code.
  - use of naming service (in #42) is now in Code.NewEventNameService
  - scrapped use of Calendar.Translations which are WIKI level (#26)
    now in Code.JSONService, too

Event/WebHome
  - probably because of the page move setting the text color
    (#19 / #22: set default to black) needed to be restored

MoccaCalendarSheet
  - the color picker fields had been reformatted upstream
    kept version from this repository

MoccaCalendarEventSheet
  - conflict between extracting a "getDateFormat" macro out of the "displayDate" macro
    and upstream change in this macro
  - conflict between new input fields for recurrent events upstream
    and a modification for the calender selection field
  - the "hidden" filter added for #49 has been migrated
    to the corresponding API code

and also the unavoidable version number clashes in the pom.xml
@ane-gabriela ane-gabriela mentioned this issue Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acotiuga acotiuga

Labels
Priority: Critical Type: Bug
Projects
None yet
Milestone
2.9.2
Development

No branches or pull requests
2 participants
@acotiuga @ane-gabriela