Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't exit on 'q' #95

Closed
yurivict opened this issue Apr 28, 2020 · 10 comments
Closed

Doesn't exit on 'q' #95

yurivict opened this issue Apr 28, 2020 · 10 comments
Assignees
Labels
area:ui Changes to the user interface bug Something isn't working os:freebsd state:confirmed Reproduced
Milestone

Comments

@yurivict
Copy link

yurivict commented Apr 28, 2020

Pressing 'q' doesn't do anything.

killing it also didn't work cleanly the first time:

$ gotop
$ 0;111;17M0;111;17mqqq`
> 
> 
> 
>    0;137;27M0;137;27m0;137;27M0;137;27mqqq
> 
> 
> 
> 

It worked cleanly later.

OS: FreeBSD 12.1
Version: 3.5.2

@xxxserxxx
Copy link
Owner

Hm. Another FreeBSD-specific bug; this one may be harder, since handling keyboard events is done by the TUI library. Do any of the keys work? Does ? bring up the help? Can you navigate the process widget?

@xxxserxxx xxxserxxx self-assigned this Apr 28, 2020
@xxxserxxx xxxserxxx added os:freebsd area:ui Changes to the user interface bug Something isn't working labels Apr 28, 2020
@yurivict
Copy link
Author

Do any of the keys work? Does ? bring up the help? Can you navigate the process widget?

No, no and no.

@yurivict
Copy link
Author

There shouldn't be any difference with Linux. It's just a terminal function, and terminals work the same way.

@xxxserxxx
Copy link
Owner

There shouldn't be any difference with Linux

In theory, there is no difference between theory and practice. In practice, there is.

I haven't had reports of it not working elsewhere; I've personally tested it on Linux (under several terminal emulators) and Darwin (default Terminal.app), so it must be an issue with the underlying kit and FreeBSD.

I have some "real work" to do over the next couple of days, but I'm going to install a FreeBSD VM on the weekend and see if I can replicate the issue. Which terminal emulator are you using?

@yurivict
Copy link
Author

In theory, there is no difference between theory and practice. In practice, there is.

Yes, but terminal interfaces are supposed to be literally identical. Differences might come from ifdefs for specific systems and versions.

@xxxserxxx xxxserxxx added this to the v3.5.3 milestone Apr 30, 2020
@xxxserxxx
Copy link
Owner

xxxserxxx commented Apr 30, 2020 via email

@xxxserxxx
Copy link
Owner

@daniejstriata FYI; I don't know if you got a copy of that message

@xxxserxxx
Copy link
Owner

@yurivict Yes; I wish it were that easy. However, bindings are working on Linux and OSX, and I now have two people saying they don't work on FreeBSD, so it seems to be FreeBSD specific. I'll be able to install FreeBSD in a VM and dig into it this weekend.

@xxxserxxx
Copy link
Owner

None of the key bindings work on BSD (at least, in a VM)

@xxxserxxx xxxserxxx added the state:confirmed Reproduced label May 8, 2020
xxxserxxx added a commit that referenced this issue May 28, 2020
xxxserxxx added a commit that referenced this issue May 31, 2020
…mit is broken because of the merge from master.
@xxxserxxx
Copy link
Owner

@yurivict are you able to confirm this fix with the v3.5.3 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui Changes to the user interface bug Something isn't working os:freebsd state:confirmed Reproduced
Projects
None yet
Development

No branches or pull requests

2 participants