Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
termui
is incompatible with the latest version oftermbox-go
, which caused highlighted text to disappear (#226). The reason behind it is thattermui
converts each terminal cell's desired colors and modifiers totermbox-go
format, using the formula present inrender.go
:termbox-go
then reads the modifiers by comparing them with defined constants. Versionv0.0.0-20190121233118-02980233997d
, marked astermui
's dependency inside itsgo.mod
, contains these definitions:However,
v1.1.1
, marked as minimum required version bygotop
, had the code above changed to:As can be seen, what was
AttrReverse
inv0.0.0-20190121233118-02980233997d
, becameAttrHidden
inv1.1.1
. It's also not hard to notice why changingtermui
'sReverseModifier
constant to1 << 15
insidegotop
's code worked as a workaround.termui
correctly marked minimum required version oftermbox-go
asv0.0.0-20190121233118-02980233997d
, but dependency bump in c3aeb75 caused a compatibility issue. Instead of removingtermbox-go
fromgo.mod
and lettingtermui
manage it, I lowered the minimum required version tov0.0.0-20200418040025-38ba6e5628f1
in order to avoid possible regression on FreeBSD (#95).Fixes #226
Fixes #235