please vendor dependencies

[mischief]

please vendor the dependencies of algernon, so that it is less likely to break when dependencies change.

glide is a great tool for this.

if you don't wish to vendor dependencies directly in algernon (which i would recommend you do), please at least create package log files with e.g. glide, so that dependency versions are pinned.

[xyproto]

Good idea! Will do.

The Homebrew packages for Algernon has versions pinned already, but I think vendoring them with Glide is an even better idea.

[mischief]

@xyproto i noticed recently you forked the sass package to avoid the git submodule, but i asked upstream to change it, and they did. so you don't need to use a fork any more :-)

[xyproto]

Thanks for the issue for the sass package, I updated the import so that it imports from wellington/sass again.

I also added a glide.yml file, but there seems to be issues when running glide install since it wants to fetch from github.com/gophertown/fsnotify, but I can't see where on earth it gets gophertown from, as it isn't mentioned in any of my sources, or in any sources in $GOPATH/src. Does the current glide.yml file work for you, or are there issues?

Would you recommend checking in a vendor directory?

[xyproto]

Do you also happen to know is srlt compares favorably to glide? I am new to both.

[mischief]

@xyproto - not clear where github.com/gophertown/fsnotify would come from.

i have never heard of srlt - but i know glide is becoming popular with many projects.

there are pros and cons of vendoring the code itself. its for you to decide as a maintainer.

if you vendor the code, you have to update it sometimes, but it allows someone to build the code even if the upstream has changed api or even gone (like github.com/gophertown/fsnotify is gone).

if you don't vendor the code, the repo is smaller. but it's slightly more difficult for someone to build a particular version (especially anyone trying to package the app), and it is possible some upstream could go away and break the build. but at least if you pin the versions in glide (or similar tool) then you worry less about changing APIs.

[mischief]

fwiw, i ended up writing this to package algernon in my gentoo overlay - https://github.com/offblast/overlay/blob/master/www-servers/algernon/algernon-1.0.ebuild

notice i did something similar to the homebrew file - download each pinned tarball of each dependency.

if algernon vendored dependencies in vendor/ directory, it might look more like https://github.com/offblast/overlay/blob/master/sys-cluster/hyperkube/hyperkube-1.4.0_beta_rc0.ebuild. simpler :-)

[xyproto]

Started using glide and vendored all the dependencies. Thanks for the tip!

Please test if it works correctly for you, if you have the chance.

[mischief]

@xyproto, it seems now pongo2 is a git submodule and not directly vendored. can it be directly vendored?

[xyproto]

Re-added the vendored dependency. Even though there were no .gitmodule file, it was left in the git index for some reason. Should be okay now.