-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure text remains visible during webfont load #5
Comments
Hey @crock, Thanks a lot for spotting that! Do you think As Guillermo Garron wrote (emphasis is mine):
I can imagine it's a tough choice: even though both options contribute to a better user experience, they do it differently (no invisible text vs no blinking text). My suggestion with What do you guys think? |
I haven't heard of Regarding its use in this repository, I'm not sure which method is objectively better. Its use of one vs the other seems situational. Personally, I prefer Here are some additional resources on the |
Would it be possible for you to re-run the diagnostics you did above, but this time with |
@mfilenko the diagnostic used above is: https://web.dev/measure/ |
Thanks! Checking... |
Hey guys, I'm very sorry it took me that long to get back to you on this one! Both Even though I personally share Garron's approach to "use swap for icons, and fallback for the rest of web fonts", I'll be totally fine with either value. xz/fonts should be fast enough for this difference to be unnoticeable anyways ;) I made this animation to illustrate how both options work: As you can see a header uses While researching this issue I also noticed that Google Fonts CSS API uses For the time being I'm totally fine with closing this issue again 😅 Thank you for being patient and open to discussions! Cheers, |
The confirmed fix is to add
display: swap;
to each of the@font-face
rules.The text was updated successfully, but these errors were encountered: