Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type inference issue in eyre macro autoderef behavior #27

Merged
merged 5 commits into from
Jun 21, 2020
Merged

fix type inference issue in eyre macro autoderef behavior #27

merged 5 commits into from
Jun 21, 2020

Conversation

yaahc
Copy link
Collaborator

@yaahc yaahc commented Jun 16, 2020 •
edited
Loading

tinkerware
tinkerware reviewed Jun 17, 2020
View reviewed changes
Copy link

@tinkerware tinkerware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for working on the fix!

@yaahc yaahc merged commit 96ddb39 into master Jun 21, 2020
@yaahc yaahc deleted the macro-fix branch June 21, 2020 17:42
@pksunkara pksunkara mentioned this pull request Oct 11, 2023
Merged
pksunkara pushed a commit that referenced this pull request Oct 11, 2023
@yaahc
depend on next version of eyre (#27)
63b8bc7 
* depend on next version of eyre

* more use statement updates

* fix line numbers for windows test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinkerware tinkerware tinkerware left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile error when returning result of eyre! macro as color_eyre::Result
2 participants
@yaahc @tinkerware