Add 1-argument ensure!($expr)
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This seems like a small and useful change, maintaining compatibility with anyhow's It looks like this failed CI due to some problems that weren't really your fault and now it's gone stale. Would you consider rebasing and updating the review now that tests are more stable and there are more folks around to handle contributions? |
sharnoff
force-pushed
the
1-argument-ensure
branch
from
75f4b4f
to
01ef1a7
Compare
|
No worries :) Rebased - no conflicts, didn't check if the changes are still valid |
thenorili
approved these changes
Nov 19, 2023
thenorili
force-pushed
the
1-argument-ensure
branch
from
01ef1a7
to
2eb184b
Compare
thenorili
force-pushed
the
1-argument-ensure
branch
from
2eb184b
to
0a21a51
Compare
|
Thanks so much for the contribution! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends a subltle difference from
anyhow. This PR is basically duplicated from dtolnay/anyhow#129.