-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Only add schemes to URLs with hostnames
Fixes: #1250 This changes the way a scheme is prefixed to a URL when linkValidation is on. Previously any URL that did not match the scheme regex would be prefixed with 'http://' which meant that an absolute path such as '/' would be changed to 'http:///' This changes it so that the 'http://' is only prefixed if the first part of the path looks like a hostname, which allows absolute paths to be unchanged and most relative paths to be unchanged. I say most as a path such as "test.txt" would be matched as a hostname and converted to 'http://test.txt' but this seems an acceptable trade off and definitely better than trying to store a list of valid TLDs so filenames and hostnames can be determined.
- Loading branch information
Showing
2 changed files
with
76 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters