Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkValidation bug in IE? #1250

Closed
LuoPQ opened this issue Nov 25, 2016 · 0 comments · Fixed by #1258
Closed

linkValidation bug in IE? #1250

LuoPQ opened this issue Nov 25, 2016 · 0 comments · Fixed by #1258
Labels
browser-ie easy first bug

Comments

@LuoPQ
Copy link

LuoPQ commented Nov 25, 2016

Steps to reproduce

  1. Select some texts
  2. Click anchor button, then enter a '/' as a link.
  3. preview then click the link, the link will be "http:///", and can't open a new tab even set the target="_blank".

Expected behavior: [What you expected to happen]
when enter "/" as link, it should be can't add "http://" before it, or open a new tab for this wrong link in IE.

Actual behavior: [What actually happened]
open the wrong link in current tab.

Versions

  • medium-editor: 5.22.1
  • browser: IE11
  • OS:window 7
kevindew added a commit to kevindew/medium-editor that referenced this issue Dec 10, 2016
@kevindew
Only add schemes to URLs with hostnames
3dfc087 
Fixes: yabwe#1250

This changes the way a scheme is prefixed to a URL when linkValidation
is on. Previously any URL that did not match the scheme regex would be
prefixed with 'http://' which meant that an absolute path such as '/'
would be changed to 'http:///'

This changes it so that the 'http://' is only prefixed if the first part
of the path looks like a hostname, which allows absolute paths to be
unchanged and most relative paths to be unchanged.

I say most as a path such as "test.txt" would be matched as a hostname and
converted to 'http://test.txt' but this seems an acceptable trade off
and definitely better than trying to store a list of valid TLDs so
filenames and hostnames can be determined.
@kevindew kevindew mentioned this issue Dec 10, 2016
Merged
kevindew added a commit to kevindew/medium-editor that referenced this issue Feb 8, 2017
@kevindew
Only add schemes to URLs with hostnames
6d67581 
Fixes: yabwe#1250

This changes the way a scheme is prefixed to a URL when linkValidation
is on. Previously any URL that did not match the scheme regex would be
prefixed with 'http://' which meant that an absolute path such as '/'
would be changed to 'http:///'

This changes it so that the 'http://' is only prefixed if the first part
of the path looks like a hostname, which allows absolute paths to be
unchanged and most relative paths to be unchanged.

I say most as a path such as "test.txt" would be matched as a hostname and
converted to 'http://test.txt' but this seems an acceptable trade off
and definitely better than trying to store a list of valid TLDs so
filenames and hostnames can be determined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser-ie easy first bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only add schemes to URLs with hostnames kevindew/medium-editor
2 participants
@j0k3r @LuoPQ