Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add schemes to URLs with hostnames #1258

Merged
merged 1 commit into from
Feb 9, 2017

Commits on Feb 8, 2017

  1. Only add schemes to URLs with hostnames

    Fixes: yabwe#1250
    
    This changes the way a scheme is prefixed to a URL when linkValidation
    is on. Previously any URL that did not match the scheme regex would be
    prefixed with 'http://' which meant that an absolute path such as '/'
    would be changed to 'http:///'
    
    This changes it so that the 'http://' is only prefixed if the first part
    of the path looks like a hostname, which allows absolute paths to be
    unchanged and most relative paths to be unchanged.
    
    I say most as a path such as "test.txt" would be matched as a hostname and
    converted to 'http://test.txt' but this seems an acceptable trade off
    and definitely better than trying to store a list of valid TLDs so
    filenames and hostnames can be determined.
    kevindew committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    6d67581 View commit details
    Browse the repository at this point in the history