Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics #32

Closed
ggrossetie opened this issue Mar 6, 2015 · 8 comments
Closed

Add metrics #32

ggrossetie opened this issue Mar 6, 2015 · 8 comments

Comments

@ggrossetie
Copy link
Contributor

I think it would be nice to have metrics/stats about Kafka server (message rate, byte in rate, byte out rate...)

AFAIK metrics/stats are not stored in Zookeeper (Ref: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper). Would you consider a pull request that retrieve metrics from Kafka server ? I could use the Kafka REST Proxy, JMX or ... ?

A simpler solution might be to get the consumer offset from curator/zookeeper /consumers/[groupId]/offsets/[topic]/[partitionId] ?

Wdyt ?

@patelh
Copy link
Collaborator

patelh commented Mar 19, 2015

This would be great. Coming from JMX may be better since I'm not sure if the REST Proxy is part of the Apache Kafka distribution or just confluence.

@ggrossetie
Copy link
Contributor Author

OK I will open a pull request to discuss implementation details.

@patelh
Copy link
Collaborator

patelh commented May 5, 2015

@Mogztter Thanks for the contrib! We are using it for our cluster. Consumer offset watcher would be nice addition too ;)

@ggrossetie
Copy link
Contributor Author

You're welcome! I'm glad that you find it useful :)
Le 5 mai 2015 7:28 AM, "patelh" notifications@github.com a écrit :

@Mogztter https://github.com/Mogztter Thanks for the contrib! We are
using it for our cluster. Consumer offset watcher would be nice addition
too ;)


Reply to this email directly or view it on GitHub
#32 (comment).

@ggrossetie
Copy link
Contributor Author

I found out that Kafka (core) have an utility class to retrieve consumer offset: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala

I will do some testing to integrate this utility class 😄

@drummerwolli
Copy link

can be closed, or? JXM Metrics are available now in KM ...

@ggrossetie
Copy link
Contributor Author

Yes I think we can close this issue now. @patelh Wdyt ?

@patelh
Copy link
Collaborator

patelh commented Sep 20, 2015

Sure.

@patelh patelh closed this as completed Sep 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants