Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sbt wrapper script? #4

Closed
miguno opened this issue Feb 4, 2015 · 3 comments
Closed

Include sbt wrapper script? #4

miguno opened this issue Feb 4, 2015 · 3 comments

Comments

@miguno
Copy link

miguno commented Feb 4, 2015

Instead of requiring the user to have a system-wide installation of sbt, it is often preferable to include the sbt wrapper script from sbt-extras (e.g. most Twitter Scala projects include this sbt wrapper).

The benefit is that the version of sbt configured in build.properties will be downloaded automatically if needed. The only change for users is that they must run sbt-related commands via ./sbt instead of sbt.

@samklr
Copy link

samklr commented Feb 4, 2015

Thought the same thing. I'm planning to run it inside a docker container ...

@patelh
Copy link
Collaborator

patelh commented Feb 8, 2015

Good idea, will add it, thanks for the suggestion!

@patelh patelh closed this as completed in 450cdd2 Feb 9, 2015
patelh added a commit that referenced this issue Feb 9, 2015
closes #4 by adding sbt from sbt-extras
@miguno
Copy link
Author

miguno commented Feb 10, 2015

I'd also update the README accordingly (https://github.com/yahoo/kafka-manager#deployment).

sbt clean dist should now be ./sbt clean dist.

mcanevet pushed a commit to camptocamp/kafka-manager that referenced this issue Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants