Ported the vrf verification feature #58

adon-at-work · 2015-09-14T11:49:49Z

This is the vrf verification implementation ported from https://github.com/yahoo/coname/blob/master/vrf/vrf.go

It lives as an utility function, and is tested with inputs and outputs captured from the original golang implementation.

Please review, thanks.

- imported js-sha3 v0.3.1 from https://github.com/emn178/js-sha3 - extended js-sha3 to support SHAKE256 (output correct up to first 1088bits) - allowed output byte array of 32 bytes

- translated the golang implementation from https://github.com/yahoo/coname/blob/master/vrf/vrf.go#L148

diracdeltas · 2015-09-14T15:43:57Z

src/javascript/crypto/e2e/vrf/sha3shake256.js

+ * Copyright 2015, emn178@gmail.com
+ * 
+ * Licensed under the MIT license:
+ * http://www.opensource.org/licenses/MIT


Should this go under the @license header? I'm not sure what is the recommended way to include the MIT license in an Apache2 project. @gyehuda

gd point. i was curious what to do too. I copied the code from there, dropped some, and added some new features. so, what's the license then? follow the MIT? or stick with the Apache as used in other files? or dual licenses? trust the expert @gyehuda can give some insights. thanks

Sorry for the delay. There are a couple of ways to address this, and it's mostly driven by project convention. Some projects have a strict process where the headers are kept consistent and that all inclusions like this are disclosed in a NOTICES file, other projects are much less strict and have what you see above -- an inclusion in the code that is preceded with the relevant license and copyright text. Both are OK. At first this latter approach is simpler, eventually the code could get messy and you'll want to clean it up.

What is most important though is that somewhere in the project you indicate that emn17 owns the copyright of some code that was licensed under the MIT license and is included in this project.

Thanks @gyehuda.
@diracdeltas, can you suggest which convention/approach you prefer?

andres-erbsen · 2015-09-15T14:10:12Z

src/javascript/crypto/e2e/vrf/extra25519.js

+
+	// e is either 1 or -1
+	// x = ev - (1-e)A/2
+	var x = e.isEqual(e2e.vrf.ed25519.curve.ONE) ? v : A.substract(v);


Please document that this is not constant time and thus must not be used with secret inputs.

adon-at-work · 2015-09-15T14:50:19Z

@andres-erbsen , once you finished reviewing this. I'll clear all the commented golang here. They're there to facilitate reviews only. OK?

adon-at-work · 2015-09-16T06:29:57Z

@andres-erbsen and @diracdeltas please check those things fixed.

Since many of those discussions are collapsed since the last commit, I list out the following discussions that are yet to be resolved for quick reference (kindly click below to have them expanded, or you may like to check each collapsed one by one):

Ref: YahooArchive/coname@671193d d089c12

adon-at-work · 2015-09-17T09:28:41Z

After the last commit, the final issue to deal with in this PR: #58 (diff)

diracdeltas · 2015-09-21T23:10:56Z

src/javascript/crypto/e2e/vrf/vrf.js

+  //  return false
+  // }
+  // hash.Reset()
+  hash = e2e.vrf.sha3Shake256(iiB.concat(m), 32);


hash is undeclared

diracdeltas · 2015-09-21T23:18:31Z

Currently, the VRF module isn't included in any of the extension files, so the compiler isn't actually checking it for correctness. When I include the vrf module in the extension (such as by prepending goog.require('e2e.vrf.verify'); to launcher.js), Closure compiler throws a lot of errors.

diracdeltas · 2015-09-21T23:37:46Z

src/javascript/crypto/e2e/vrf/extra25519.js

+goog.require('e2e.ecc.PrimeCurve');
+goog.require('e2e.error.InvalidArgumentsError');
+
+var ed25519 = e2e.ecc.DomainParam.fromCurve(e2e.ecc.PrimeCurve.ED_25519);


Declaring variables/functions like this will pollute the global namespace. Please make sure everything is contained in the module namespace. Ex: e2e.vrf.extra255519.ed25519_ = e2e.ecc.DomainParam.fromCurve(e2e.ecc.PrimeCurve.ED_25519)

The underscore at the end of a name indicates to the compiler that this variable is private (should not be accessed outside of the current module).

makes sense.

adon-at-work · 2015-09-22T01:50:39Z

Currently, the VRF module isn't included in any of the extension files, so the compiler isn't actually checking it for correctness. When I include the vrf module in the extension (such as by prepending goog.require('e2e.vrf.verify'); to launcher.js), Closure compiler throws a lot of errors.

the errors are cleared.

adon-at-work · 2015-09-22T02:30:43Z

I'm done with the suggested changes.

The build was failed due to an upstream commit (happened roughly an hour ago):
google/closure-templates@e47f247

Tracking the issue at google/closure-templates#57

diracdeltas · 2015-09-28T21:01:33Z

src/javascript/crypto/e2e/vrf/extra25519.js

+ * @param {!e2e.ecc.Element} r the representative coordinate
+ * @return {!e2e.ecc.Element}
+ */
+function representativeToMontgomeryX(r) {


Please put this in the e2e.vrf.extra25519 namespace

to leverage the faster new interfaces update() and digest()

adon-at-work · 2015-09-28T23:32:37Z

@diracdeltas , all done. upgraded to use the latest js-sha3 too

diracdeltas · 2015-09-29T18:02:10Z

Thanks, LGTM! @andres-erbsen any objections to merging?

Ported the vrf verification feature

andres-erbsen · 2015-10-02T21:32:35Z

src/javascript/crypto/e2e/vrf/extra25519.js

+ * @param {!e2e.ByteArray} h A byte array of length 32
+ * @return {!e2e.ecc.point.Ed25519}
+ */
+e2e.vrf.extra25519.hashToEdwards = function(h) {


Please document that this is not constant time (because variable-length bignums aren't)

andres-erbsen · 2015-10-02T21:39:30Z

No objections. I did add two one-line documentation nits about functions that are not constant-time-ish, though.

adon added 2 commits September 14, 2015 19:31

added sha3 SHAKE256 lib

495c367

- imported js-sha3 v0.3.1 from https://github.com/emn178/js-sha3 - extended js-sha3 to support SHAKE256 (output correct up to first 1088bits) - allowed output byte array of 32 bytes

added vrf verify implementation

8762f42

- translated the golang implementation from https://github.com/yahoo/coname/blob/master/vrf/vrf.go#L148

diracdeltas reviewed Sep 14, 2015
View reviewed changes

adon-at-work force-pushed the feature/vrf branch from d5d7311 to 8762f42 Compare September 15, 2015 03:34

andres-erbsen reviewed Sep 15, 2015
View reviewed changes

adon-at-work mentioned this pull request Sep 16, 2015

add sample test vectors for vrf.verify() YahooArchive/coname#25

Merged

updated according to reviewer's comments

5fb4753

match the latest golang implementation

7d001a6

Ref: YahooArchive/coname@671193d d089c12

adon-at-work mentioned this pull request Sep 17, 2015

Crypto: ED_25519 base x order = infinity? google/end-to-end#340

Open

cleaned up sha3 impl. according to @andres-erbsen's comments

9e03e29

adon-at-work force-pushed the feature/vrf branch from a245658 to 9e03e29 Compare September 17, 2015 10:15

diracdeltas reviewed Sep 21, 2015
View reviewed changes

addressed @diracdeltas comments

0c3a29e

adon-at-work force-pushed the feature/vrf branch from 714aad3 to 0c3a29e Compare September 22, 2015 01:32

Fallback to use a buildable version of closure-templates compiler

6e2342a

adon-at-work force-pushed the feature/vrf branch from de0ff59 to 6e2342a Compare September 22, 2015 04:39

diracdeltas reviewed Sep 28, 2015
View reviewed changes

adon added 2 commits September 28, 2015 15:33

dealt with namespacing

adece73

upgrade to use the new SHA3 implementation

88e0514

to leverage the faster new interfaces update() and digest()

diracdeltas added a commit that referenced this pull request Oct 2, 2015

Merge pull request #58 from yahoo/feature/vrf

8bf5dca

Ported the vrf verification feature

diracdeltas merged commit 8bf5dca into master Oct 2, 2015

diracdeltas deleted the feature/vrf branch October 2, 2015 05:24

andres-erbsen reviewed Oct 2, 2015
View reviewed changes

adon-at-work mentioned this pull request Oct 6, 2015

documented hashToEdwards and hashToCurve are not constant time #60

Merged

liamsi mentioned this pull request Aug 12, 2016

Registration function arlolra/ctypes-otr#84

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ported the vrf verification feature #58

Ported the vrf verification feature #58

adon-at-work commented Sep 14, 2015

diracdeltas Sep 14, 2015

adon-at-work Sep 15, 2015

gyehuda Sep 17, 2015

adon-at-work Sep 17, 2015

andres-erbsen Sep 15, 2015

adon-at-work Sep 16, 2015

adon-at-work commented Sep 15, 2015

adon-at-work commented Sep 16, 2015

adon-at-work commented Sep 17, 2015

diracdeltas Sep 21, 2015

adon-at-work Sep 21, 2015

diracdeltas commented Sep 21, 2015

diracdeltas Sep 21, 2015

adon-at-work Sep 21, 2015

adon-at-work commented Sep 22, 2015

adon-at-work commented Sep 22, 2015

diracdeltas Sep 28, 2015

adon-at-work commented Sep 28, 2015

diracdeltas commented Sep 29, 2015

andres-erbsen Oct 2, 2015

andres-erbsen commented Oct 2, 2015

Ported the vrf verification feature #58

Ported the vrf verification feature #58

Conversation

adon-at-work commented Sep 14, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adon-at-work commented Sep 15, 2015

adon-at-work commented Sep 16, 2015

adon-at-work commented Sep 17, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diracdeltas commented Sep 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adon-at-work commented Sep 22, 2015

adon-at-work commented Sep 22, 2015

Choose a reason for hiding this comment

adon-at-work commented Sep 28, 2015

diracdeltas commented Sep 29, 2015

Choose a reason for hiding this comment

andres-erbsen commented Oct 2, 2015