-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganizes the asynchronous classes. #19
Merged
Merged
Commits on Aug 31, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 1f3903b - Browse repository at this point
Copy the full SHA 1f3903bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29ea79d - Browse repository at this point
Copy the full SHA 29ea79dView commit details -
Removes all timing from the JobsApiRequestSpec.
-- The spec has test that verifies that when the timeout expires, an empty Observable is emitted. However, the timeout was 2 milliseconds, and the main test thread was only sleeping 5 milliseconds before sending the message. These two times were too close together, so that the test may result in a false failure in a highly contested environment (i.e. Travis). In order to avoid this problem, the timing element has been removed completely: -- We now assert that the Observable received by the Subscriber completes without sending any values (i.e. the Observable subscribed to is empty).
Configuration menu - View commit details
-
Copy full SHA for b8a57a8 - Browse repository at this point
Copy the full SHA b8a57a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d61beaa - Browse repository at this point
Copy the full SHA d61beaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 056219e - Browse repository at this point
Copy the full SHA 056219eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a290fd - Browse repository at this point
Copy the full SHA 2a290fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33efa2c - Browse repository at this point
Copy the full SHA 33efa2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b8d09e - Browse repository at this point
Copy the full SHA 3b8d09eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84e4be9 - Browse repository at this point
Copy the full SHA 84e4be9View commit details -
Reorganizes the asynchronous classes.
-- Before everything was shoved into the single jobs package. Now, the package structure has been made much more organized (and hopefully) tractable.
Configuration menu - View commit details
-
Copy full SHA for 0c154a6 - Browse repository at this point
Copy the full SHA 0c154a6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.