Reorganizes the asynchronous classes. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| def "We are able to get the correct self url"() { | ||
| expect: | ||
| JobPayloadBuilder.getSelfUrl("ticket1", uriInfo) == "https://localhost:9998/v1/jobs/ticket1" | ||
| JobPayloadBuilder.getSelfUrl("ticket1", uriInfo) == "https://localhost:9998/v1/async/ticket1" |
There was a problem hiding this comment.
I checked with Rick and he was under the impression that the api endpoint should still be jobs and not async. (Applies elsewhere as well)
There was a problem hiding this comment.
Yes, that should still be jobs. My renaming got a bit overzealous, it looks like.
archolewa
force-pushed
the
async-packages
branch
3 times, most recently
from
efb3798
to
3bcfb56
Compare
|
👍 |
|
👍 |
-- The spec has test that verifies that when the timeout expires, an empty Observable is emitted. However, the timeout was 2 milliseconds, and the main test thread was only sleeping 5 milliseconds before sending the message. These two times were too close together, so that the test may result in a false failure in a highly contested environment (i.e. Travis). In order to avoid this problem, the timing element has been removed completely: -- We now assert that the Observable received by the Subscriber completes without sending any values (i.e. the Observable subscribed to is empty).
archolewa
force-pushed
the
async-packages
branch
from
3bcfb56
to
15effd9
Compare
-- Before everything was shoved into the single jobs package. Now, the package structure has been made much more organized (and hopefully) tractable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Before everything was shoved into the single jobs package. Now, the
package structure has been made much more organized (and hopefully)
tractable.