Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

Fix "nav.params is not an object" error #107

Merged
merged 1 commit into from
Dec 8, 2015

Conversation

geta6
Copy link
Contributor

@geta6 geta6 commented Dec 7, 2015

When FluxibleRouter does not match any routes, handleHistory component always throw nav.params is not an object error in client side.

This error occurred by handleHistory:componentDidUpdate try to get params from null (from getDefaultProps), so I fixed it.

Before

After

@Vijar Vijar added the ready label Dec 7, 2015
@mridgway
Copy link
Collaborator

mridgway commented Dec 7, 2015

lgtm 👍

@yahoocla
Copy link

yahoocla commented Dec 7, 2015

CLA is valid!

@redonkulus
Copy link
Contributor

👍

redonkulus added a commit that referenced this pull request Dec 8, 2015
Fix "nav.params is not an object" error
@redonkulus redonkulus merged commit 060565d into YahooArchive:master Dec 8, 2015
@redonkulus redonkulus removed the ready label Dec 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants