This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
[wip] added ability to rewrite the route #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
|
||
| debug('handleNavigateStart route not changed'); | ||
| }, | ||
| handleRewriteRoute: function (payload) { |
|
Minor comments but 👍 |
|
I'm starting to wonder if this should be handled differently. It's basically a special case for something that isn't really route related. Others have asked for 404 handling within the router, although 500 handling doesn't really fit within the router at all. I wonder if this should be handled outside of the router entirely. |
|
Maybe we can support a not found route configuration option and leave the 500s up to the app. This would be similar |
|
Closing for now. Moving these ideas to #14. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to essentially swap out the route handler without changing the URL.
The current use case is to support 404/500 pages. I have a PR for integrating
fluxible-routerinto www.fluxible.io to help demonstrate. See: https://github.com/yahoo/fluxible.io/pull/120REWRITE_ROUTERouteStore