This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
Add onbeforeunload support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
Changes Unknown when pulling 62926f1 on gfranko:add-onbeforeunload-support into * on yahoo:master*. |
|
Changes Unknown when pulling a7ceed9 on gfranko:add-onbeforeunload-support into * on yahoo:master*. |
|
👍 @mridgway @redonkulus ? |
|
👍 can you please squash your commits? |
|
Changes Unknown when pulling a38d507 on gfranko:add-onbeforeunload-support into * on yahoo:master*. |
gfranko
force-pushed
the
add-onbeforeunload-support
branch
from
a38d507
to
520eba4
Compare
|
Changes Unknown when pulling 520eba4 on gfranko:add-onbeforeunload-support into * on yahoo:master*. |
Added window.onbeforeunload functionality to fluxible-router Make sure to delete the onbeforeunload method if a user wants to navigate to a different page Removed logic from the navigate action and added logic for the handleHistory lib and the NavLink component per @mridgway Remove unneccessary commented out code Be safer about getting the current route map Remove jsdom from the navigateAction-test.js file Removed ynpm debug log Updated .gitignore Reverted .gitignore Updated with changes per @lingyan Remove the currentUrl condition per @lingyan Updated Remove the currentUrl condition per @lingyan Updated per @lingyan
gfranko
force-pushed
the
add-onbeforeunload-support
branch
from
520eba4
to
e8aee87
Compare
|
@redonkulus Squashed! |
|
Changes Unknown when pulling e8aee87 on gfranko:add-onbeforeunload-support into * on yahoo:master*. |
1 similar comment
|
Changes Unknown when pulling e8aee87 on gfranko:add-onbeforeunload-support into * on yahoo:master*. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the situation when a user leaves a particular page and the
window.onbeforeunload()method needs to be called. #16Note: This is almost idential to the flux-router-component PR that I created.