This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Added compatibility with Y.Model #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@focuzz this is definitely needed. Can you provide the tests as well as part of this pull request? |
|
@caridy probably, but I haven't worked with yuitest yet, so it'll take some time... |
|
n.p. I will try to help. |
|
@caridy Do You use gtalk? |
|
@focuzz yes I do! username: caridy |
|
see also issue #259 |
|
seems to me this patch does the right thing regardless of Y.Model 👍 |
|
is this getting merged into master anytime soon? |
|
I hope to get this merged this week. |
|
@add0n does this fall under your current investigation? |
|
This falls under the refactor proposed for 0.6.x where models are more flexible, and mojito will not try to do much with them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bug #259