-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new QBG methods to C API #138
Comments
Hello,
|
Hello, Thank you for the updates and the explanations. However I am not sure to understand your answer regarding void qbg_initialize_construction_parameters(QBGConstructionParameters *parameters)
{
// ...
parameters->internal_data_type = NGTQ::DataTypeFloat;
parameters->data_type = NGTQ::DataTypeFloat;
// ...
} So I thought that we could also use Actually, if I try to set them both to
|
Hello, |
Hello,
|
Thanks a lot, it works fine now ! Looking at your commit it seems that QBG can also handle float16 ? Does QG handle float16 too ? |
Since I found that v2.0.15 does not work well in some cases, I have released v2.0.16 to fix it. QG and QBG can handle float16 as well. |
Thank you for the precision. Then I guess some more functions would be needed in the C API for float16, I will list them in #141 |
Hello,
Following up on #136, in order to have a type-safe API in
ngt-rs
for QBG indexes, the following functions would be required in the C API:On a related topic, I have questions about the
QBGConstructionParameters
:What is the
internal_data_type
? Should it always be the same asdata_type
?Similarly, what is
extended_dimension
compared todimension
? Are there some rules between them ?The text was updated successfully, but these errors were encountered: