Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix Mode - Safari caret position after new tag #328

Closed
matrixengine opened this issue Oct 10, 2019 · 17 comments
Closed

Mix Mode - Safari caret position after new tag #328

matrixengine opened this issue Oct 10, 2019 · 17 comments
Labels

Comments

@matrixengine
Copy link

Hi,

In Safari for Mac, when adding a new tag, the cursor jumps to the start of the tag opposed to the end. This means when you start typing it actually types before the tag not after.

I don't mind doing a bit of self diag, but could you point me in the right direction? Might need some sort of timeout before re-positioning the cursor after the tag add function has completed.

--

It would also be great if you can add the option in mix mode of forcing a space after a tag when added. I know currently it adds a zero width space, but it would be of benefit to have a visual space to maintain formatting when tags are used within a sentence.

Thanks.

@yairEO
Copy link
Owner

yairEO commented Oct 11, 2019

Does this also happens in Chrome (Mac)?

A good place to start debugging is this method

@matrixengine
Copy link
Author

No, just safari :(

@yairEO
Copy link
Owner

yairEO commented Oct 14, 2019

Please try now with latest version: 2.31.0 and let me know

@yairEO yairEO added the Bug label Oct 14, 2019
@tagspace
Copy link

This is unfortunately still an issue in Safari (on Mac). Works fine in Chrome.

@yairEO
Copy link
Owner

yairEO commented Dec 12, 2019

Just released version 3.0.0 so this should work. Try updating Tagify and check.

Also, added a new position setting for the dropdown, which should be very useful in mixed-mode.

set dropdown.position to text and the dropdown should appear next to the caret, while typing.

@tagspace
Copy link

Thanks @yairEO . Just tested it out. Unfortunately still an issue. Here is a video of the problem (in latest version of Safari): https://recordit.co/im73msH7Qo

And a gif version: http://g.recordit.co/im73msH7Qo.gif

@tagspace
Copy link

@yairEO if I open this JsBin in Safari and add some tags (using the @ symbol), every time the cursor is to the left of the tag:
https://jsbin.com/wokovon/edit?html,js,output

@yairEO
Copy link
Owner

yairEO commented Dec 14, 2019

You are using older version in your demo (pre v3), please clone this one

Also, I don't have a Mac to test Safari at the moment, it might take a few months to come by a Mac. I really hope that using v3 will work on your Safari

@tck
Copy link

tck commented Dec 19, 2019

Tested with Version 3.2.0. The caret problem also exists in Firefox (v71). Chrome works perfect.

@yairEO
Copy link
Owner

yairEO commented Dec 20, 2019

Tried your demo on FF v71 and it seems to work when selecting tags with the keyboard. The caret stays at the end.

GIF

But there is a completely different bug: when selecting a tag with the mouse, and that tag was the last one (no text after it) then nothing can be written in the input afterwards, regardless of focus.

@yairEO
Copy link
Owner

yairEO commented Dec 20, 2019

I have made a little change in the new 3.2.2 version, so you can try it now and report

@tck
Copy link

tck commented Dec 20, 2019

Thx for your changes. Still have the problem some times. See this fiddle:
https://jsfiddle.net/zdq5nck9/
After focus the field some times i got the caret after the last tag. Some times there is no caret.

@tagspace
Copy link

tagspace commented Jan 8, 2020

Hi @yairEO. I've just noticed that BrowserStack have a free plan for Open Source projects: https://www.browserstack.com/pricing (see bottom of page).

Would that be helpful for testing issues like this? Happy to help you apply for this if I can help in any way.

@yairEO
Copy link
Owner

yairEO commented Jan 25, 2020

Maybe now using tagify@3.3.0 ?

@sut10
Copy link

sut10 commented Jun 3, 2020

This issue still exists with tagify v3.10.2 using Safari v13.1. The caret remains before the tag that was inserted using the whitelist dropdown.

@yairEO
Copy link
Owner

yairEO commented Jun 6, 2020

Ok, finnaly got to it and fixed it.
will release a new version tomorrow along with the fix!

Sorry for the long delay

@yairEO yairEO closed this as completed in 469f732 Jun 10, 2020
@ShishoA
Copy link

ShishoA commented Mar 11, 2021

Hi Yair
still not working on Safari
did you find some bug about that issue ?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants