-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mix Mode - Safari caret position after new tag #328
Comments
Does this also happens in Chrome (Mac)? A good place to start debugging is this method |
No, just safari :( |
Please try now with latest version: |
This is unfortunately still an issue in Safari (on Mac). Works fine in Chrome. |
Just released version Also, added a new set |
Thanks @yairEO . Just tested it out. Unfortunately still an issue. Here is a video of the problem (in latest version of Safari): https://recordit.co/im73msH7Qo And a gif version: http://g.recordit.co/im73msH7Qo.gif |
@yairEO if I open this JsBin in Safari and add some tags (using the @ symbol), every time the cursor is to the left of the tag: |
You are using older version in your demo (pre v3), please clone this one Also, I don't have a Mac to test Safari at the moment, it might take a few months to come by a Mac. I really hope that using |
Tested with Version 3.2.0. The caret problem also exists in Firefox (v71). Chrome works perfect. |
Tried your demo on FF But there is a completely different bug: when selecting a tag with the mouse, and that tag was the last one (no text after it) then nothing can be written in the input afterwards, regardless of focus. |
I have made a little change in the new |
Thx for your changes. Still have the problem some times. See this fiddle: |
Hi @yairEO. I've just noticed that BrowserStack have a free plan for Open Source projects: https://www.browserstack.com/pricing (see bottom of page). Would that be helpful for testing issues like this? Happy to help you apply for this if I can help in any way. |
Maybe now using |
This issue still exists with tagify v3.10.2 using Safari v13.1. The caret remains before the tag that was inserted using the whitelist dropdown. |
Ok, finnaly got to it and fixed it. Sorry for the long delay |
Hi Yair |
Hi,
In Safari for Mac, when adding a new tag, the cursor jumps to the start of the tag opposed to the end. This means when you start typing it actually types before the tag not after.
I don't mind doing a bit of self diag, but could you point me in the right direction? Might need some sort of timeout before re-positioning the cursor after the tag add function has completed.
--
It would also be great if you can add the option in mix mode of forcing a space after a tag when added. I know currently it adds a zero width space, but it would be of benefit to have a visual space to maintain formatting when tags are used within a sentence.
Thanks.
The text was updated successfully, but these errors were encountered: