Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

Issue with reactjs ? #144

Closed
juanonsoftware opened this issue Aug 7, 2018 · 3 comments
Closed

Issue with reactjs ? #144

juanonsoftware opened this issue Aug 7, 2018 · 3 comments

Comments

@juanonsoftware
Copy link

Hi,
Thanks for the great library !
I want to use this with reactjs but having an issue: the thumbs at bottom is not visible, and in chrome console having an uncaught error: this.imageLinks.size is not a function at C.generate (jquery.photobox.js:452)
Any help would be highly appreciated. Thanks.

@juanonsoftware
Copy link
Author

It looks like that v1.9.2 works. Not sure if that's a bug on newer releases. Thanks.

@yairEO
Copy link
Owner

yairEO commented Sep 9, 2018

I don't see anywhere this.imageLinks.size in the source code of photobox

@yairEO yairEO closed this as completed Sep 9, 2018
@digggggggggg
Copy link

I've had the same problem and this.imageLinks.size(); appears in the CDNJS hosted version of the plugin: https://cdnjs.cloudflare.com/ajax/libs/photobox/1.9.9/photobox/jquery.photobox.min.js

I believe it's from version 1.9.2.

Version 1.9.9 doesn't have this issue,

len = this.imageLinks.length,

And the mix-up might have occurred because in your releases 1.9.2 appears later than 1.9.9
https://github.com/yairEO/photobox/releases

Would it be possible to address this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants