Bug !!!

[dickermoshe]

Adding this to the original KosherJava package was a mistake:

kosher_dart/lib/src/zmanim_calendar.dart

Line 309 in 465e2cc

DateTime? getCandleLighting() {

The original package does not account whether there is Candle Lighting on that day, or whether to calculate 18 min before sunset on Shabbos or after Tzais on 2nd day Yom Tov or 3-day Yom Tov.

You also don't account for second day Yom Tov outside of the US.
You only reference the possibility of a 2 day yom tov for JewishCalendar.ROSH_HASHANA.

Running the following code for the US on April 6th 2023 will crash even though there is candle lighting on that date.

ComplexZmanimCalendar zmanim = ComplexZmanimCalendar.intGeoLocation(geoLocation);
bool isThereCandleLighting = JewishCalendar.fromDateTime(z.getCalendar()).hasCandleLighting();
if (isThereCandleLighting){
    zmanim.getCandleLighting() // <<-- Will still return null !!!!!
}

The complexities of KosherJava are such that any port should try to copy it exactly.

[yakir8]

thinks i am closing this the fix is on kosher_dart 2.0.17