1.4.0-beta3 (for testing before release) #451

averissimo · 2016-11-27T15:26:28Z

See beta4 #464

.

1.4.0-beta3

Please report all BUGS related to 1.4.0-beta3 here

Include a screenshot (or copy the console log) when reporting.

Download: 1.4.0-beta4 is available through this link

It includes almost all the pull requests currently pending, so a lot of new improvements and bug fixes.

Thanks to @aPoCoMiLogin @chasetb @mattsigal for the help in MacOSX testing

Difference to beta1 (see whole conversation at issue #445)

Copy/Paste/Cut working on MacOSX
Native about window problem solved, now calls on new "About" (MacOSX)
- Help menu item is removed from MacOSX
Sending Multiple Photos/Images #450
About window is now created on demand instead of being pre-loaded at the beginning.

1.4.0 list of new features/fix/experimental

New Features:

[FEATURE] Embedded photos in chat messages (Received images not coming through #407)
[FEATURE] Image preview when pasting or adding images via selector (Image preview when pasting or adding images via selector #398)
[FEATURE] 'Help -> About' window ('Help -> About' window #423)
[FEATURE] Add startup screen and fix window position on startup (Fix window position on startup #418)
[FEATURE] Switching between hide window and clear input when pressing 'escape' key ([DO NOT MERGE] Switching between hide window and clear input when pressing 'escape' key #409)
[FEATURE] Feature Request: Notification Privacy (Feature Request: Notifications format option which does not reveal name and message received #386 and #386 Feature Request: Notification Privacy #399)
[FEATURE] Add "show popup notifications" option to tray (Add "show popup notifications" option to tray #393)
[FEATURE] Debugging: All errors from main window are shown in command line (Debugging: All errors from main window are shown in command line #426)

Bug fixes

[FIX] Fix on not fitting images in conversations list (Fix on not fitting images in conversations list #430)
[Fix] menu icon in dark scheme (Menu icon in "Dark" color scheme is not clearly visible #433 and #433 Fix menu icon in dark scheme #437)
[Fix] fallback to initials when thumbnail image not available fallback to initials when thumbnail image not available #428
[FIX] fix deploy.sh and add --no-zip option (Fix deploy.sh and add --no-zip option #424)
[FIX] Fix 'event.keyIdentifier' depreciation in favour of 'event.key' (Fix 'event.keyIdentifier' depreciation in favour of 'event.key' #419)
[FIX] fixes three bugs with emojis (Emoji replacement inserts "undefined" for emjois that don't exist #412 and Issue #412 -- fixes three bugs with emojis #413)
[FIX] menus had a typo 'getAccelarator' should be 'getAccelerator' ([URGENT] menus had a typo 'getAccelarator' should be 'getAccelerator' #403)
[FIX] Make hide the window (close to tray) work on all platforms if "Close (Make hide the window (close to tray) work on all platforms if "Close … #397)

Experimental (now fully working)

[Experimental] Shows who has seen each message group ([NEED HELP] Shows who has seen each message group #429)

aPoCoMiLogin · 2016-11-27T19:09:17Z

There are few things that is something wrong with them (at least on OSX).

--

First (more important) is error when yakyak is closed (CMD+Q or right click -> quit from dock), when started from terminal then this is shown:

$ ./Applications/YakYak.app/Contents/MacOS/YakYak 
hconnect
reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
resolved proxy DIRECT
resolved proxy DIRECT
connected 0
Error on YakYak window:
 { columnNo: 17,
  error: {},
  lineNo: 143,
  msg: 'Uncaught TypeError: Cannot read property \'isFullScreen\' of undefined',
  url: 'file:///Applications/YakYak.app/Contents/Resources/app/ui/app.js' } 
--- End of error message in YakYak window.
Segmentation fault: 11

It not occurs all the time, on 10 attpemts it occurs 2 times. But still something is up with that.

--

Second is about window from #423 poping up after CMD+H on OSX. It pops when yakyak just started and CMD+H is used. Was wonder if something is triggering it, so edited main.js and added console.trace to check from where that trigger is coming from:

ipc.on('show-about', function() {
      console.trace();
      aboutWindow.setMenu(null);
      return aboutWindow.show();
});

but this gots triggered only when menu about is clicked. This is how it looks like: https://goo.gl/photos/v8ZP5S7un2ukGMH4A

--

Third thing is something that I can't explain, did not found any html element responsible for it https://goo.gl/photos/gCX3RGQUpEJB7FSg6 it show up only in material and dark color scheme.

--

Last thing is an error when there is no contact to show:

$ ./Applications/YakYak.app/Contents/MacOS/YakYak
hconnect
reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
resolved proxy DIRECT
resolved proxy DIRECT
connected 0
Error on YakYak window:
 { columnNo: 10,
  error: {},
  lineNo: 103,
  msg: 'Uncaught TypeError: Cannot read property \'current_participant\' of undefined',
  url: '/Applications/YakYak.app/Contents/Resources/app/ui/views/messages.js' } 
--- End of error message in YakYak window.
Error on YakYak window:
 { columnNo: 10,
  error: {},
  lineNo: 103,
  msg: 'Uncaught TypeError: Cannot read property \'current_participant\' of undefined',
  url: '/Applications/YakYak.app/Contents/Resources/app/ui/views/messages.js' } 
--- End of error message in YakYak window.
Error on YakYak window:
 { columnNo: 10,
  error: {},
  lineNo: 103,
  msg: 'Uncaught TypeError: Cannot read property \'current_participant\' of undefined',
  url: '/Applications/YakYak.app/Contents/Resources/app/ui/views/messages.js' } 
--- End of error message in YakYak window.
Error on YakYak window:
 { columnNo: 10,
  error: {},
  lineNo: 103,
  msg: 'Uncaught TypeError: Cannot read property \'current_participant\' of undefined',
  url: '/Applications/YakYak.app/Contents/Resources/app/ui/views/messages.js' } 
--- End of error message in YakYak window.

averissimo · 2016-11-27T23:31:34Z

wow, fantastic bug finding and debugging skills :)

Solved by simpling checking if object actually appears.
Stopped pre-loading about window, let's see if this solves it
Can't reproduce it. Does it happen all the time? try uploading an image to see if it is a problem with the new uploading interface (when sliding on)
Solved it (although I believe this exception has no consequence)

Available in beta3, I just updated this issue to beta3 (no point on starting a new one)

ps. interesting that other than the about window all others were already existing bugs

aPoCoMiLogin · 2016-11-28T08:44:42Z

Well, my "luck" was involved :D just created new account and logged in, then found that 2 issues, which looks like are solved.

Can't reproduce that strange thing in textarea, so it might got solved or it was something on my side. Anyway good job on fixing it 👍

* 1.4.0-beta3: fix bug that prevented same image from being sent twice in a row harmless error, but needs to be checked correct check, help only shows in os other than macosx about menu is created on request, instead of pre-loaded fix error on some yakyak program exits yakyak#451 using https url instead of ssh correct window menu no longer use native about window adds issue of zoomin shortcut corrects fatal bug update to newer versions of electron

cawka · 2016-12-01T02:32:51Z

Today, the old and the beta versions (tried also the master branch) suddenly stopped working with the following error in console:

reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
resolved proxy DIRECT
resolved proxy DIRECT
connect_failed TypeError: Cannot read property 'length' of undefined
    at /Users/cawka/Downloads/yakyak/node_modules/hangupsjs/lib/init.js:125:20
    at _fulfilled (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:796:13)
    at /Users/cawka/Downloads/yakyak/node_modules/q/q.js:556:49
    at runSingle (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:137:13)
    at flush (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
error connecting TypeError: Cannot read property 'length' of undefined
    at /Users/cawka/Downloads/yakyak/node_modules/hangupsjs/lib/init.js:125:20
    at _fulfilled (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:796:13)
    at /Users/cawka/Downloads/yakyak/node_modules/q/q.js:556:49
    at runSingle (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:137:13)
    at flush (/Users/cawka/Downloads/yakyak/node_modules/q/q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Anyway it can be fixed?

averissimo · 2016-12-01T03:48:09Z

google changed stuff -_-

I'm uploading a new 1.4.0 release.. but it will take some time

@cawka If you want to test if this fix works do the following in the master branch (or any other that was working)

remove directories
- node_modules/hangupsjs
- app/node_modules/hangupsjs
run npm install and npm run gulp to reinstall hangupsjs
make sure you got the latest by
- grep -A 1 email node_modules/hangupsjs/lib/init.js
- output should be as image below (ds:36 is twhat you should have! not ds:33)

cawka · 2016-12-01T03:52:43Z

Yeah, I understand that the core problem was google making changes.

Thank you very much for addressing this issue quickly. Your suggestion fixed the issue and I'm back to my normal workflow (yakyak really solved so many problems for me with hangouts).

Send message too quickly. With the suggestion, I'm able to login and see the contact list, but still cannot do anything else. I see the following in the console:

--- End of error message in YakYak window.
Error on YakYak window:
 { columnNo: 49,
  error: {},
  lineNo: 73,
  msg: 'Uncaught TypeError: Cannot read property \'value\' of null',
  url: '/Users/cawka/Downloads/yakyak/app/ui/models/viewstate.js' }
--- End of error message in YakYak window.

averissimo · 2016-12-01T04:06:38Z

@cawka that's in which branch?

averissimo · 2016-12-01T04:07:35Z

can you paste here the block of code around line 73 of that file?

cawka · 2016-12-01T04:09:59Z

Tried with d37842f commit of 1.4.0-beta4 branch from you repo.

Here is value of viewstate.js around those lines:

switchInput: function(next_conversation_id) {
      var el;
      el = document.getElementById('message-input');
      this.messageMemory[this.selectedConv] = el.value;
      if (this.messageMemory[next_conversation_id] != null) {
        el.value = this.messageMemory[next_conversation_id];
        return this.messageMemory[next_conversation_id] = "";
      } else {
        return el.value = '';
      }
    },

Will try different branch(es) and report if it works.

averissimo · 2016-12-01T04:10:56Z

try with 1.4.0 from yakyak/yakyak, i've just updated it

cawka · 2016-12-01T04:15:10Z

1.4.0 branch works! Thanks!

averissimo · 2016-12-01T04:17:00Z

yay! \o/

can you test one other feature?

write something in the text area
switch conversations
- see if it cleared the text area
switch back
- see if it remembers the old text

cawka · 2016-12-01T04:19:18Z

Works. Tried with several conversations.

averissimo · 2016-12-01T04:20:10Z

thanks :fist_bump:

averissimo · 2016-12-01T04:34:13Z

closing this issue as beta4 is out

see #464 or download latest pre-release from official yakyak

averissimo mentioned this issue Nov 27, 2016

1.4.0 Wrapper pull request #452

Merged

averissimo added a commit to averissimo/yakyak that referenced this issue Nov 27, 2016

fix error on some yakyak program exits yakyak#451

73090b2

averissimo added a commit to averissimo/yakyak that referenced this issue Nov 27, 2016

fix error on some yakyak program exits yakyak#451

b5e16e6

averissimo changed the title ~~1.4.0-beta2 (for testing before release)~~ 1.4.0-beta3 (for testing before release) Nov 27, 2016

averissimo mentioned this issue Nov 27, 2016

Sending Multiple Photos/Images #450

Closed

averissimo added a commit to averissimo/yakyak that referenced this issue Nov 29, 2016

fix error on some yakyak program exits yakyak#451

2399218

This was referenced Nov 29, 2016

Tray icon not turning green when a new message arrives #432

Closed

after login, blank in KDE-Neon #425

Closed

averissimo added this to the 1.4.0 milestone Nov 29, 2016

averissimo added the enhancement label Nov 30, 2016

averissimo mentioned this issue Nov 30, 2016

no cmd-tab entry when dock item is hidden #316

Closed

averissimo closed this as completed Dec 1, 2016

cmurf mentioned this issue Oct 24, 2018

connect_failed TypeError: Cannot read property 'length' of undefined #978

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.4.0-beta3 (for testing before release) #451

1.4.0-beta3 (for testing before release) #451

averissimo commented Nov 27, 2016 •

edited

aPoCoMiLogin commented Nov 27, 2016

averissimo commented Nov 27, 2016 •

edited

aPoCoMiLogin commented Nov 28, 2016

cawka commented Dec 1, 2016

averissimo commented Dec 1, 2016 •

edited

cawka commented Dec 1, 2016 •

edited

averissimo commented Dec 1, 2016

averissimo commented Dec 1, 2016

cawka commented Dec 1, 2016

averissimo commented Dec 1, 2016 •

edited

cawka commented Dec 1, 2016

averissimo commented Dec 1, 2016

cawka commented Dec 1, 2016

averissimo commented Dec 1, 2016

averissimo commented Dec 1, 2016

1.4.0-beta3 (for testing before release) #451

1.4.0-beta3 (for testing before release) #451

Comments

averissimo commented Nov 27, 2016 • edited

See beta4 #464

1.4.0-beta3

Please report all BUGS related to 1.4.0-beta3 here

Download: 1.4.0-beta4 is available through this link

Difference to beta1 (see whole conversation at issue #445)

1.4.0 list of new features/fix/experimental

New Features:

Bug fixes

Experimental (now fully working)

aPoCoMiLogin commented Nov 27, 2016

averissimo commented Nov 27, 2016 • edited

aPoCoMiLogin commented Nov 28, 2016

cawka commented Dec 1, 2016

averissimo commented Dec 1, 2016 • edited

cawka commented Dec 1, 2016 • edited

averissimo commented Dec 1, 2016

averissimo commented Dec 1, 2016

cawka commented Dec 1, 2016

averissimo commented Dec 1, 2016 • edited

cawka commented Dec 1, 2016

averissimo commented Dec 1, 2016

cawka commented Dec 1, 2016

averissimo commented Dec 1, 2016

averissimo commented Dec 1, 2016

averissimo commented Nov 27, 2016 •

edited

averissimo commented Nov 27, 2016 •

edited

averissimo commented Dec 1, 2016 •

edited

cawka commented Dec 1, 2016 •

edited

averissimo commented Dec 1, 2016 •

edited