Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window position on startup #418

Merged
merged 7 commits into from Nov 29, 2016

Conversation

averissimo
Copy link
Member

Having a blank window that shifts position and then changes to normal interface when starting YakYak has been bothering me for a while

This should fix it, both the positioning and the blank window in normal startups.

I've tested this PR with:

  • clean userData (removing .config/yakyak)
  • already logged in user

Can't think of any other scenario where it is relevant, help anyone?

Also tested it with a imposed bug in menu.coffee and it shows an empty window (which I think is a good thing as the user sees something that is nothing -- being able to report it)

ps. removed extra ; as bonus :)

The message is instead displayed in screen below logo
 as is updated if connection fails during loading of contacts
@averissimo averissimo force-pushed the fix-window-position-on-startup branch from 98aa137 to d5c9f4a Compare October 17, 2016 16:50
@averissimo
Copy link
Member Author

Added a startup screen (see end of this comment for screencast)

Startup screen does:

  • Hide the dialog in the top right of the screen
  • The "Connecting" text is always synced with that diaglog content
  • The loading contacts appears when a successful connection is made (change happens on update:connection
  • The contacts are considered loaded when addentities is finished
    • if there is a better place to put this, please let me know
  • Nice fade out animation to show real interface

Preview:

note that in the preview the animation shows the logo and text longer than it actually appears (this is a glitch from a low frame per seconds in gif)

outgnmnkmdmv7

@averissimo
Copy link
Member Author

One last commit to help with debugging when UI does not render correctly.

Commit aa883a2 show mainWindow's menu, until event ready-to-show is triggered (which hides it)

In my environment if an error occurs the window is shown, in this case, the menu is still accessible and the user can open the DevTools

@averissimo averissimo mentioned this pull request Oct 25, 2016
@davibe davibe merged commit edfccba into yakyak:master Nov 29, 2016
@averissimo averissimo deleted the fix-window-position-on-startup branch November 29, 2016 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants