Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist query in URL parameters #16

Open
ErikBoesen opened this issue Sep 28, 2020 · 3 comments
Open

Persist query in URL parameters #16

ErikBoesen opened this issue Sep 28, 2020 · 3 comments

Comments

@ErikBoesen
Copy link
Collaborator

ErikBoesen commented Sep 28, 2020

One kind of nice (although very bugged) thing that the Yale Face Book does is that when you run a search, the search information is stored in the URL. That way, if you want to send someone the results of your search, you can just copy and paste the URL, which would be something like:

yalies.io/?query=Some+name&filters=...
@ErikBoesen ErikBoesen added the good first issue Good for newcomers label Mar 21, 2021
@jeffreyjgong jeffreyjgong self-assigned this Oct 11, 2021
@jeffreyjgong
Copy link
Contributor

@ErikBoesen Any hints on how to go about getting started on this?

@ErikBoesen
Copy link
Collaborator Author

@jeffreyjgong Check this out; see if you can first figure out how to add the URL parameters based on the query and filters without making the page reload. The variable called criteria holds the parameters that we use for each search; figure out how to convert that into URL parameters.

The next step would be to add some code that will run on load to check what's in the query parameters and use that to reassemble the criteria variable.

@jeffreyjgong jeffreyjgong linked a pull request Oct 31, 2021 that will close this issue
@ericyoondotcom
Copy link
Contributor

we NEEEEED this feature

@ericyoondotcom ericyoondotcom added fix after rewrite and removed good first issue Good for newcomers labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants