Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeTable has unnecessary omitObject #1325

Closed
3 tasks
hirotomoyamada opened this issue Apr 29, 2024 · 2 comments · Fixed by #1420
Closed
3 tasks

NativeTable has unnecessary omitObject #1325

hirotomoyamada opened this issue Apr 29, 2024 · 2 comments · Fixed by #1420
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Need help

Comments

@hirotomoyamada
Copy link
Member

Which package has an issue?

@yamada-ui/react

Package Version

1.3.7

Description

Integrate omitObject handling with omitThemeProps.

- const { className, layout, ...rest } = omitThemeProps(mergedProps)
+ const { className, layout, ...rest } = omitThemeProps(mergedProps, ["withBorder", "withColumnBorders", "highlightOnHover"])
<ui.table
  ref={ref}
  className={cx("ui-table", className)}
  __css={css}
-   {...omitObject(rest, [
-     "withBorder",
-     "withColumnBorders",
-     "highlightOnHover",
-   ])}
+   {...rest}
/>

Link to Reproduction

No response

Steps to Reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

Browser

None

Operating System

  • macOS
  • Windows
  • Linux

Do you know how to fix the issue?

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix?

None

Additional Information

No response

@hirotomoyamada hirotomoyamada added bug Something isn't working good first issue Good for newcomers labels Apr 29, 2024
@github-actions github-actions bot added the help wanted Need help label May 3, 2024
@ShionTerunaga
Copy link
Contributor

I would like to challenge this issue.

@hirotomoyamada
Copy link
Member Author

Hi, thanks for the comment.

Yes, pls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Need help
Projects
None yet
2 participants