Skip to content
This repository has been archived by the owner on Oct 22, 2023. It is now read-only.

Text highlighting #141

Closed
nvllz opened this issue Jul 10, 2023 · 3 comments
Closed

Text highlighting #141

nvllz opened this issue Jul 10, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@nvllz
Copy link

nvllz commented Jul 10, 2023

This would be very useful to allow text highlighting, especially when it comes to definition and example lines. This way we could share text directly from the app without having to switch apps.
Now, when you long tap on the definition text, it gets copied to the clipboard, and I think that's a nice feature. But I'd either make it copy to the clipboard on a single tap and highlight it on a long tap (so you can get a system context popup for easy sharing, etc.), or highlight the line text when you long tap the icon.

@yamin8000 yamin8000 self-assigned this Jul 10, 2023
@yamin8000 yamin8000 added the enhancement New feature or request label Jul 10, 2023
@yamin8000
Copy link
Owner

This would be very useful to allow text highlighting, especially when it comes to definition and example lines. This way we could share text directly from the app without having to switch apps.
Now, when you long tap on the definition text, it gets copied to the clipboard, and I think that's a nice feature. But I'd either make it copy to the clipboard on a single tap and highlight it on a long tap (so you can get a system context popup for easy sharing, etc.), or highlight the line text when you long tap the icon.

Screenshot_2023-07-18-14-17-45-580_io.github.yamin8000.owl.jpg

It seems text highlighting is not as good in Compose as I expected, however, it needs more investigation. So far it only provides only one button to copy, no option to share directly from the app.

@nvllz
Copy link
Author

nvllz commented Jul 18, 2023

What about this? https://stackoverflow.com/questions/68956792/floating-toolbar-for-text-selection-jetpack-compose/68966424#68966424

If this doesn't work, maybe let's make some dialog popup when long tapping the icon with some options to copy, share etc..?

@yamin8000
Copy link
Owner

What about this? https://stackoverflow.com/questions/68956792/floating-toolbar-for-text-selection-jetpack-compose/68966424#68966424

If this doesn't work, maybe let's make some dialog popup when long tapping the icon with some options to copy, share etc..?

For now, I added a simple feature to make text selectable to copy, I may add that version later. I'll make a dedicated issue for that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants