Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo background #84

Closed
jvanhoefer opened this issue Feb 3, 2021 · 5 comments
Closed

Logo background #84

jvanhoefer opened this issue Feb 3, 2021 · 5 comments
Labels
question Further information is requested

Comments

@jvanhoefer
Copy link
Member

I just changed the logo of the organization to our rocket (somehow not always shown...).

Is for you the background of the square also dark grey, or is this only due to me dark theme in GitHub (looks ugly tbh, maybe we should think of using a version, that has a white background, if these kinds of problems happen more frequent...)

@jvanhoefer jvanhoefer added the question Further information is requested label Feb 3, 2021
@jvanhoefer
Copy link
Member Author

image

Here is proof

@jvanhoefer
Copy link
Member Author

Might also be the colorblind me, who doesn't like the grey-in-grey...

@dilpath
Copy link
Member

dilpath commented Feb 4, 2021

Seems to be in the GitHub style sheets that the background of logos is set to this grey colour. The rocket blends in a bit at smaller sizes especially, to me. One solution could be to add a small stroke to the rocket (and possibly the red/blue parts).

This is GitHub-specific and is not an issue in general for the logo, e.g. see the README (currently can only be viewed on a PR branch)
https://github.com/yaml2sbml-dev/yaml2sbml/tree/fix_logo_link

@yannikschaelte
Copy link
Member

I find all logos to look bad in GitHub dark mode as it adds that grey background even if the logo would be compatible wit black as in our case. I think the only solution would be to use a alpha != 0 white background, but I kind of prefer the no-background.

@jvanhoefer
Copy link
Member Author

fine with that. having a white block around es not to nice on the dark mode either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants