Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed htmlelements-matchers. Resolves #69. #125

Closed
wants to merge 1 commit into from
Closed

Removed htmlelements-matchers. Resolves #69. #125

wants to merge 1 commit into from

Conversation

ham1
Copy link
Contributor

@ham1 ham1 commented Jun 10, 2016 •
edited
Loading

@ham1
Copy link
Contributor Author

ham1 commented Oct 16, 2017

Is this still valid and worth fixing merge issues or should this and #69 be closed?

@artkoshelev
Copy link
Contributor

Yep, it's still valid

@ham1
Copy link
Contributor Author

ham1 commented Oct 19, 2017

Updated PR, can this be merged or is there something which needs merging into https://github.com/yandex-qatools/matchers-java ?

@artkoshelev
Copy link
Contributor

@lanwen @leonsabr any objections?

@lanwen
Copy link
Contributor

lanwen commented Oct 21, 2017

I think it should be leaved as is. @eroshenkoam have a beta of new version in a separate repo

@ham1 ham1 closed this Nov 23, 2017
@ham1 ham1 deleted the remove_matchers_ branch November 23, 2017 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ham1 @artkoshelev @lanwen