Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about "Y_bbox_helper" in helper_net.py line 253 #25

Open
Darknesszlx opened this issue Feb 5, 2020 · 1 comment
Open

Question about "Y_bbox_helper" in helper_net.py line 253 #25

Darknesszlx opened this issue Feb 5, 2020 · 1 comment

Comments

@Darknesszlx
Copy link

var Y_bbox_helper in helper_net.py line 253 is used for finding valid gt boxes. After sum operation, Y_bbox_helper maybe less than 0, so adding an abs operation before greater operation maybe a better solution.

@Yang7879
Copy link
Owner

Yang7879 commented Feb 5, 2020

Hi @Darknesszlx , thank you for the good suggestion. So far the sum operation is fine because we use the "zero-one-center" to preprocess the point clouds, which means all the vertices of gt boxes are always positive. But I agree with you using abs operation will make the code more reliable in case the data are preprocessed in another way.

use_zero_one_center = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants