Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to eslint v4 #1251

Closed
inakiarroyo opened this issue Jun 12, 2017 · 6 comments
Closed

Support to eslint v4 #1251

inakiarroyo opened this issue Jun 12, 2017 · 6 comments

Comments

@inakiarroyo
Copy link

eslint v4.00 has been released, will there be a close upgrade to support the new version ?
@yannickcr
Copy link
Member

This plugin should already work with ESLint 4.0.0 since v7.0.1. Official support (no peerDependencies warning) is already merged and should be released with the next version (most likely today or tomorrow).

@frankandrobot
Copy link

frankandrobot commented Jun 13, 2017 •
edited
Loading

Actually, in npm, v7.0.1 does NOT have eslint 4.0.0 as a peer dependency. You need to bump a patch version and re-publish.

@ljharb
Copy link
Member

ljharb commented Jun 13, 2017 •
edited
Loading

The peer dep would need to be ^3 || ^4 for it work with both v3 and v4 - which it looks like it is, as of e7836b5 - but that's unreleased.

ljharb referenced this issue Jun 13, 2017
@yannickcr
Add ESLint 4.0.0 to peerDependencies
e7836b5
@frankandrobot
Copy link

yea that's what I said

This was referenced Jun 13, 2017
Closed
Merged
@frenchie4111
Copy link

Can someone npm publish this change please?

@yannickcr
Copy link
Member

Just published v7.1.0 with ESLint 4.0.0 as peer dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yannickcr @ljharb @frankandrobot @frenchie4111 @inakiarroyo