Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Does not validate for LogicalExpression #2533

Merged

Conversation

@toshi-toma
Copy link
Contributor

toshi-toma commented Dec 24, 2019

Fixes #2526.

…pression
const returnsConditionalJSX = strict ?
(returnsConditionalJSXConsequent && returnsConditionalJSXAlternate) :
(returnsConditionalJSXConsequent || returnsConditionalJSXAlternate);
return strict ?

This comment has been minimized.

Copy link
@toshi-toma

toshi-toma Dec 24, 2019

Author Contributor

I think strict property not used. So, I should probably remove strict property from isReturningJSXOrNull.

@toshi-toma toshi-toma changed the title [Fix]: Does not validate missing propTypes for LogicalExpression [Fix]: Does not validate for LogicalExpression Dec 25, 2019
@ljharb
ljharb approved these changes Dec 26, 2019
lib/util/Components.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the toshi-toma:fix-prop-types-with-logicalExpression branch 2 times, most recently from 6eab9e1 to f02e8ae Dec 26, 2019
@ljharb ljharb merged commit f02e8ae into yannickcr:master Dec 26, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 97.515%
Details
@toshi-toma
Copy link
Contributor Author

toshi-toma commented Dec 27, 2019

Thanks!!

@toshi-toma toshi-toma deleted the toshi-toma:fix-prop-types-with-logicalExpression branch Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.