Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] jsx-newline support prevent option #2935

Merged
merged 1 commit into from Mar 23, 2021

Conversation

@jsphstls
Copy link
Contributor

@jsphstls jsphstls commented Feb 27, 2021

Closes: #2793

@lukasgjetting
Copy link

@lukasgjetting lukasgjetting commented Mar 1, 2021

Awesome!

Maybe the rule config should use the terms "always" and "never" instead of prevent (like semi)?

Not sure though, as that might limit future configuration without introducing breaking changes.

@lukasgjetting
Copy link

@lukasgjetting lukasgjetting commented Mar 1, 2021

Duplicate of #2927?

@jsphstls
Copy link
Contributor Author

@jsphstls jsphstls commented Mar 1, 2021

I can rename the options. I did use an object to make it easier to extend. What do you think @ljharb ?

@sladyn98
Copy link

@sladyn98 sladyn98 commented Mar 2, 2021

This is great ! Thanks for solving it I was actually finding it quite difficult to find my way around it. I can understand and learn 🎉

@ljharb
ljharb approved these changes Mar 23, 2021
@ljharb ljharb force-pushed the jsphstls:2793-prevent-jsx-newline branch from 1c9bca3 to a686079 Mar 23, 2021
@ljharb ljharb merged commit a686079 into yannickcr:master Mar 23, 2021
43 checks passed
43 checks passed
@github-actions
Automatic Rebase
Details
@github-actions
Require “Allow Edits”
Details
@github-actions
matrix
Details
@github-actions
pretest
Details
@github-actions
readme
Details
@github-actions
latest majors (15, 7)
Details
@github-actions
posttest
Details
@github-actions
latest majors (15, 6)
Details
@github-actions
latest majors (15, 5)
Details
@github-actions
latest majors (15, 4)
Details
@github-actions
latest majors (14, 7)
Details
@github-actions
latest majors (14, 6)
Details
@github-actions
latest majors (14, 5)
Details
@github-actions
latest majors (14, 4)
Details
@github-actions
latest majors (13, 7)
Details
@github-actions
latest majors (13, 6)
Details
@github-actions
latest majors (13, 5)
Details
@github-actions
latest majors (13, 4)
Details
@github-actions
latest majors (12, 7)
Details
@github-actions
latest majors (12, 6)
Details
@github-actions
latest majors (12, 5)
Details
@github-actions
latest majors (12, 4)
Details
@github-actions
latest majors (11, 7)
Details
@github-actions
latest majors (11, 6)
Details
@github-actions
latest majors (11, 5)
Details
@github-actions
latest majors (11, 4)
Details
@github-actions
latest majors (10, 7)
Details
@github-actions
latest majors (10, 6)
Details
@github-actions
latest majors (10, 5)
Details
@github-actions
latest majors (10, 4)
Details
@github-actions
latest majors (9, 6)
Details
@github-actions
latest majors (9, 5)
Details
@github-actions
latest majors (9, 4)
Details
@github-actions
latest majors (8, 6)
Details
@github-actions
latest majors (8, 5)
Details
@github-actions
latest majors (8, 4)
Details
@github-actions
latest majors (7, 5)
Details
@github-actions
latest majors (7, 4)
Details
@github-actions
latest majors (6, 5)
Details
@github-actions
latest majors (6, 4)
Details
@github-actions
latest majors (5, 4)
Details
@github-actions
latest majors (4, 4)
Details
@github-actions
node 4+
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants