Add context props to sort-comp #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, why not! 👍 |
|
That order seems fine and since we can always override it if desired then I'd say this is pretty good. |
|
Seems fine to me too, great addition! |
yannickcr
added a commit
that referenced
this pull request
May 29, 2015
Add context props to sort-comp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although technically undocumented, context is very widely used, and it sucks to have to override
lifecycleto just fit them in.I don't really have a strong opinion on where they fit in the order, but I kinda based it on the order in which they're defined in https://github.com/facebook/react/blob/52752446760dee0bc7232b4146f5a309ac57f065/src/isomorphic/classic/class/ReactClass.js#L115-L159. I can put them in any other order if you'd like.