Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell completions #4

Open
yannjor opened this issue May 8, 2022 · 3 comments
Open

Add shell completions #4

yannjor opened this issue May 8, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@yannjor
Copy link
Owner

yannjor commented May 8, 2022

Add shell completions for the name command. This should be possible with clap. See: https://dev.to/kbknapp/cli-shell-completions-in-rust-37g1

@yannjor yannjor added the enhancement New feature or request label May 8, 2022
@rafaeljacov
Copy link

Hello, I'm currently implementing it, would you advise if I should generate the completions at compile-time or at runtime instead?
(PS. This will be my first ever contribution in open source)

@yannjor
Copy link
Owner Author

yannjor commented Oct 4, 2024

Hey @rafaeljacov ! Awesome that you want to contribute. Complile-time would probably be better in terms of performance.

@rafaeljacov
Copy link

Hey @rafaeljacov ! Awesome that you want to contribute. Complile-time would probably be better in terms of performance.

that's what I thought too but since starship and zoxide both implement it in runtime I just went with it also because it is really easy to source it in the shell config for the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants