Git: Merge develop branch to master
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actions: Add CI workflow
GitHub: Update CI workflow + add PR template
Making use of cobra pkg in order to create the CLI with ease.
CLI: Initial basic CLI
Internal output logic
Actions: Add Go cache
As we want to generate multiple mutations or queries for GraphQL, the given examples should reflect that: making use of GraphQL aliases. https://graphql.org/learn/queries/#aliases
generate: Fix test cases
FormattedInput formats the given input and append two spaces to the front of every line. This allows this formatted input to be fed into the generator.
mutations: Integrate CLI command with generate pkg
Since this tool is for GraphQL, it can be used with a `queries` or `mutations` command like: - generate-multifields queries - generate-multifields mutations There was no need for a `-gql`. Just to shorten the CLI's name a _slight_ bit.
Rename to drop -gql from CLI name
Was previously only concentrating on the Go parts.
CLI: Rename CLI properly
There is an issue trying to pull from GitHub when working in a private repository when Go tries to get a module/pkg. Since we are working in relative path (be it development or Dockerfile), we can make use of the replace directive to point to the relative path. https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive
Docker: Dockerize the CLI into a Docker image
Instead of working off a `develop` branch, make use of the `master` branch as staging. Afterwards, release process should be based off the `master` branch.
Git: Migrate to `master` branch as staging
This was referenced Apr 11, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up of PR #13, this Pull Request merges all commits made on the
developbranch into themasterbranch to follow a new branching strategy.From post-merge of this PR, all features/hotfixes/etc. should be made off
masterbranch.masterbranch will serve as the staging environment.Notes
The
developbranch will be removed after merging. Also, the default branch will be changed fromdeveloptomaster.