Report statusCode and uri accurately for POSTs #57 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build appears to be failing with this PR.
Are you sure this isn't supposed to be |
Fixes issue yaorg#57 by listening on the `res.on('finish')` instead of req.on('end')` event. Due to some quirk with express bodyParsers, `req.route` and `res.statusCode` were undefined in the req.on('end') event.
avolfson
force-pushed
the
avolfson-patch-issue-57
branch
from
428b37e
to
3bd6cfb
Compare
|
Added a reproducing integration test and updated the unit test, so now the fix's PR is in good shape. |
|
Is there anyway to update the example at https://yaorg.github.io/node-measured/packages/measured-signalfx-reporter/tutorial-SignalFx%20Express%20Full%20End%20to%20End%20Example.html to mention that this middleware must precede bodyParser middleware? This was another bug that was hard to discover for me 😆 |
|
Yeah it's in the tutorial folder at the root of the project.
On Sat, Feb 2, 2019 at 8:40 AM avolfson ***@***.***> wrote:
Is there anyway to update the example at
https://yaorg.github.io/node-measured/packages/measured-signalfx-reporter/tutorial-SignalFx%20Express%20Full%20End%20to%20End%20Example.html
to mention that this middleware must *precede* bodyParser middleware?
This was another bug that was hard to discover for me 😆
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArcLkmX4-qgV7S27zi3cCM74IcWxmTlks5vJb-QgaJpZM4aZZls>
.
--
Justin Field
fieldju@gmail.com
LinkedIn <https://www.linkedin.com/in/fieldju> | @fieldju
|
avolfson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a listener on the
req.on('end')event,req.routeandres.statusCodeare undefined. Switching tores.on('finish')makes these values available.#57