Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d3.geomap 2.0.0alpha: "this is null" in choropleth.draw in FireFox and iOS #41

Closed
yaph opened this issue May 29, 2017 · 2 comments
Closed

d3.geomap 2.0.0alpha: "this is null" in choropleth.draw in FireFox and iOS #41

yaph opened this issue May 29, 2017 · 2 comments

Comments

@yaph
Copy link
Owner

yaph commented May 29, 2017

The super call fails since this is not defined and nothing gets drawn.
yaph added a commit that referenced this issue May 29, 2017
@yaph
Fix issue #41:
bf1050c 
    - Call map draw with selection as only argument
    - Remove draw method from choropleth class
    - Assign map.data in geomap.js to selection.datum()
Use uncompressed sources in example files.
@yaph yaph modified the milestone: v2 May 29, 2017
@yaph
Copy link
Owner Author

yaph commented May 29, 2017

FireFox works after changes to draw method and its calls, but iOS still doesn't work.

@yaph
Copy link
Owner Author

yaph commented May 30, 2017

Works with map.draw(selection) API change. Created #42 for unresolved iOS bug(s).

@yaph yaph closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yaph