Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change in #101, the wormhole cannot toggle from render in place to render elsewhere, because
destinationElement
CP is never read and therefore the observer will never fire whenrenderInPlace
has changed. (Issue #104).I'm little unclear why we need the change from #101, but presumably we want to specify an explicit element to be used as a wormhole rather than selector. In this case, we will need to a new computed property (private) to capture all possible parameters, which
ember-wormhole
component can receive and observe them for changes.If there are other reasons, we can discuss a different fix for the issue.