Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression 0.5.3 to 0.5.4] Toggling renderInPlace #104

Closed
offirgolan opened this issue Feb 11, 2018 · 0 comments
Closed

[Regression 0.5.3 to 0.5.4] Toggling renderInPlace #104

offirgolan opened this issue Feb 11, 2018 · 0 comments

Comments

@offirgolan
Copy link

I just noticed a regression going from v0.5.3 to the latest (v0.5.4). Toggling renderInPlace in the latest version only works the first time. Once the content is rendered in place, it can no longer be wormhole'd out.

I've created a twiddle to demonstrate this. Just click on the toggle button a few times and you'll see what I mean. If you switch the addon version to 0.5.3, it will work as expected.

Ember Twiddle

offirgolan added a commit to adopted-ember-addons/ember-burger-menu that referenced this issue Feb 11, 2018
offirgolan added a commit to adopted-ember-addons/ember-burger-menu that referenced this issue Feb 12, 2018
* Run codemod

* Upgrade dependencies

* Fix ember-wormhole to 0.5.3

yapplabs/ember-wormhole#104

* Add bower to install script
dnachev pushed a commit to dnachev/ember-wormhole that referenced this issue Jun 13, 2018
lukemelia added a commit that referenced this issue Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant